Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Expand popup window (fixes #6078) - #6693

Merged
Hainish merged 1 commit into
EFForg:masterfrom
Hainish:fix-popup-ui
Sep 1, 2016
Merged

Hainish merged 1 commit into
EFForg:masterfrom
Hainish:fix-popup-ui

Conversation

@Hainish

@Hainish Hainish commented Sep 1, 2016 •

Copy link
Copy Markdown
Member

Fixes #6078
@fuglede how does this look?

In order to test, apply the following patch:

diff --git a/test/firefox/test_profile_skeleton/prefs.js b/test/firefox/test_profile_skeleton/prefs.js
index 42b3f0a..7ff28e9 100644
--- a/test/firefox/test_profile_skeleton/prefs.js
+++ b/test/firefox/test_profile_skeleton/prefs.js
@@ -1,7 +1,7 @@
 // Submit SSL Observatory reports.
-user_pref("extensions.https_everywhere._observatory.enabled", true);
+//user_pref("extensions.https_everywhere._observatory.enabled", true);
 // Don't show any popups that might get in the way of testing.
-user_pref("extensions.https_everywhere._observatory.popup_shown", true);
+//user_pref("extensions.https_everywhere._observatory.popup_shown", true);
 user_pref("extensions.https_everywhere.toolbar_hint_shown", true);
 // Show all logs.
 user_pref("extensions.https_everywhere.LogLevel", 0);

@Hainish

Hainish commented Sep 1, 2016

Copy link
Copy Markdown
Member Author

I'm going to jump procedure here and merge this in myself. I know it's bad form, but seeing that the fix requires a very minor code change and that I'll be making a release today, I'd rather have this issue fixed now rather than wait until next release.

@Hainish
Hainish merged commit 47531ab into EFForg:master Sep 1, 2016
@fuglede

fuglede commented Oct 16, 2016

Copy link
Copy Markdown
Contributor

I finally got around to testing this on a Windows machine again; I can confirm that the dialog looks normal in a clean profile on Firefox 49 on Windows 8.

@Hainish
Hainish deleted the fix-popup-ui branch February 23, 2018 01:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants